change: rename esptool underscore arguments and subcommands to dash #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates esptool command-line arguments and subcommands to use dashes instead of underscores, following the updated esptool naming convention.
- Changed underscore-based command names to dash-based equivalents (e.g.,
erase_flash→erase-flash) - Updated flash-related command arguments to use dashes (e.g.,
--flash_mode→--flash-mode) - Applied changes consistently across all pytest-embedded modules that use esptool
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pytest-embedded-serial-esp/pytest_embedded_serial_esp/serial.py | Updated erase_flash command to erase-flash |
| pytest-embedded-qemu/pytest_embedded_qemu/app.py | Changed merge_bin to merge-bin in binary creation |
| pytest-embedded-nuttx/pytest_embedded_nuttx/serial.py | Updated flash arguments and write_flash command to dash format |
| pytest-embedded-idf/pytest_embedded_idf/serial.py | Changed multiple esptool commands including write_flash, erase_region, and read_flash |
| pytest-embedded-arduino/pytest_embedded_arduino/serial.py | Updated write_flash command to write-flash |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.